Implement `slice::split_once` and `slice::rsplit_once` #112818

Benjamin-L · 2023-06-20T01:23:17Z

Feature gate is slice_split_once and tracking issue is #112811. These are equivalents to the existing str::split_once and str::rsplit_once methods.

Feature gate is slice_split_once and tracking issue is rust-lang#112811.

rustbot · 2023-06-20T01:23:25Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Benjamin-L · 2023-10-08T06:36:34Z

r? libs

cuviper · 2023-10-09T18:27:04Z

LGTM!

@bors r+

bors · 2023-10-09T18:27:06Z

📌 Commit 50246b0 has been approved by cuviper

It is now in the queue for this repository.

bors · 2023-10-09T19:05:37Z

⌛ Testing commit 50246b0 with merge 4226f40...

…uviper Implement `slice::split_once` and `slice::rsplit_once` Feature gate is `slice_split_once` and tracking issue is rust-lang#112811. These are equivalents to the existing `str::split_once` and `str::rsplit_once` methods.

rust-log-analyzer · 2023-10-09T20:06:04Z

The job x86_64-apple-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

SCCACHE_BUCKET=rust-lang-ci-sccache2
SCRIPT=./x.py --stage 2 test tests/ui tests/rustdoc tests/run-make-fulldeps
SHELL=/bin/bash
SHLVL=3
SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.DlzAra4mAk/Listeners
STATS_EXTP=https://provjobdsettingscdn.blob.core.windows.net/settings/provjobdsettings-0.5.154/provjobd.data
STATS_RDCL=true
STATS_TIS=mining
STATS_TRP=true
---
---- [ui] tests/ui/panics/default-backtrace-ice.rs stdout ----
diff of stderr:

7 
8 aborting due to `-Z treat-err-as-bug=1`
- (end_short_backtrace)
11 (begin_short_backtrace)
12 (end_short_backtrace)
13 (begin_short_backtrace)
---
To only update this specific test, also pass `--test-args panics/default-backtrace-ice.rs`

error: 1 errors occurred comparing output.
status: exit status: 101
command: env -u RUST_BACKTRACE RUSTC_ICE="0" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/work/rust/rust/tests/ui/panics/default-backtrace-ice.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/Users/runner/.cargo" "--sysroot" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2" "--target=x86_64-apple-darwin" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/ui/panics/default-backtrace-ice" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/native/rust-test-helpers" "-L" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/ui/panics/default-backtrace-ice/auxiliary" "-Z" "treat-err-as-bug=1"
--- stderr -------------------------------
error[E0425]: cannot find value `missing_ident` in this scope
##[error]  --> /Users/runner/work/rust/rust/tests/ui/panics/default-backtrace-ice.rs:21:13
   |
   |
LL | fn main() { missing_ident; }

thread 'rustc' panicked at compiler/rustc_errors/src/lib.rs:1729:30:
thread 'rustc' panicked at compiler/rustc_errors/src/lib.rs:1729:30:
aborting due to `-Z treat-err-as-bug=1`
   0:        0x109eb080b - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h8958f94563609657
   1:        0x109f10ed3 - core::fmt::write::hdd43aa90d6a43cdd
   2:        0x109ea5aae - std::io::Write::write_fmt::h02fe55ec2386a618
   3:        0x109eb05e9 - std::sys_common::backtrace::print::hdc3746c1d1790af0
   3:        0x109eb05e9 - std::sys_common::backtrace::print::hdc3746c1d1790af0
   4:        0x109eb39e5 - std::panicking::default_hook::{{closure}}::h857c800f71339c11
   5:        0x109eb374c - std::panicking::default_hook::ha6d1edd10122218c
   6:        0x11284f07c - std[8e1823cd7d97ede3]::panicking::update_hook::<alloc[843ab6373c3127d6]::boxed::Box<rustc_driver_impl[4ea838747b1f4058]::install_ice_hook::{closure#0}>>::{closure#0}
   8:        0x109eb3e27 - std::panicking::begin_panic_handler::{{closure}}::h2863807219d00231
   9:        0x109eb0d19 - ___udivmoddi4
  10:        0x109eb3b9d - _rust_begin_unwind
  11:        0x109f3c215 - core::panicking::panic_fmt::hb94cfcfbdb6d18be
  11:        0x109f3c215 - core::panicking::panic_fmt::hb94cfcfbdb6d18be
  12:        0x11734accf - <rustc_errors[d70416c97ff7ccbd]::HandlerInner>::panic_if_treat_err_as_bug
  13:        0x11734a017 - <rustc_errors[d70416c97ff7ccbd]::HandlerInner>::emit_diagnostic::{closure#2}
  14:        0x1129b93bf - rustc_interface[f401208f1fc4bb82]::callbacks::track_diagnostic
  15:        0x11734997e - <rustc_errors[d70416c97ff7ccbd]::HandlerInner>::emit_diagnostic
  16:        0x11735a691 - <rustc_span[d50c010c06298d00]::ErrorGuaranteed as rustc_errors[d70416c97ff7ccbd]::diagnostic_builder::EmissionGuarantee>::diagnostic_builder_emit_producing_guarantee
  17:        0x115cd861d - <rustc_resolve[7ec0af2e7f610273]::Resolver>::report_errors
  18:        0x115d56593 - <rustc_session[119c3cf30fd3d126]::session::Session>::time::<(), <rustc_resolve[7ec0af2e7f610273]::Resolver>::resolve_crate::{closure#0}>
  19:        0x115d0bbfe - <rustc_resolve[7ec0af2e7f610273]::Resolver>::resolve_crate
  21:        0x11635bf8d - rustc_query_impl[601865046abf9999]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[601865046abf9999]::query_impl::resolver_for_lowering::dynamic_query::{closure#2}::{closure#0}, rustc_middle[519fc4c290d6e6fc]::query::erase::Erased<[u8; 8usize]>>
  21:        0x11635bf8d - rustc_query_impl[601865046abf9999]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[601865046abf9999]::query_impl::resolver_for_lowering::dynamic_query::{closure#2}::{closure#0}, rustc_middle[519fc4c290d6e6fc]::query::erase::Erased<[u8; 8usize]>>
  22:        0x11643fca9 - <rustc_query_impl[601865046abf9999]::query_impl::resolver_for_lowering::dynamic_query::{closure#2} as core[8666913e49efa5c]::ops::function::FnOnce<(rustc_middle[519fc4c290d6e6fc]::ty::context::TyCtxt, ())>>::call_once
  23:        0x1162ae57b - rustc_query_system[26b2b5e851988277]::query::plumbing::try_execute_query::<rustc_query_impl[601865046abf9999]::DynamicConfig<rustc_query_system[26b2b5e851988277]::query::caches::SingleCache<rustc_middle[519fc4c290d6e6fc]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[601865046abf9999]::plumbing::QueryCtxt, false>
  24:        0x11639699a - rustc_query_impl[601865046abf9999]::query_impl::resolver_for_lowering::get_query_non_incr::__rust_end_short_backtrace
  25:        0x11280b796 - <rustc_middle[519fc4c290d6e6fc]::ty::context::GlobalCtxt>::enter::<rustc_driver_impl[4ea838747b1f4058]::run_compiler::{closure#1}::{closure#2}::{closure#4}, &rustc_data_structures[9883a995ac86ee0b]::steal::Steal<(rustc_middle[519fc4c290d6e6fc]::ty::ResolverAstLowering, alloc[843ab6373c3127d6]::rc::Rc<rustc_ast[c447bfbffb1467b]::ast::Crate>)>>
  26:        0x112830636 - rustc_span[d50c010c06298d00]::set_source_map::<core[8666913e49efa5c]::result::Result<(), rustc_span[d50c010c06298d00]::ErrorGuaranteed>, rustc_interface[f401208f1fc4bb82]::interface::run_compiler<core[8666913e49efa5c]::result::Result<(), rustc_span[d50c010c06298d00]::ErrorGuaranteed>, rustc_driver_impl[4ea838747b1f4058]::run_compiler::{closure#1}>::{closure#0}::{closure#0}>
  27:        0x1128159ec - std[8e1823cd7d97ede3]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[f401208f1fc4bb82]::util::run_in_thread_with_globals<rustc_interface[f401208f1fc4bb82]::interface::run_compiler<core[8666913e49efa5c]::result::Result<(), rustc_span[d50c010c06298d00]::ErrorGuaranteed>, rustc_driver_impl[4ea838747b1f4058]::run_compiler::{closure#1}>::{closure#0}, core[8666913e49efa5c]::result::Result<(), rustc_span[d50c010c06298d00]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[8666913e49efa5c]::result::Result<(), rustc_span[d50c010c06298d00]::ErrorGuaranteed>>
  28:        0x11281719e - <<std[8e1823cd7d97ede3]::thread::Builder>::spawn_unchecked_<rustc_interface[f401208f1fc4bb82]::util::run_in_thread_with_globals<rustc_interface[f401208f1fc4bb82]::interface::run_compiler<core[8666913e49efa5c]::result::Result<(), rustc_span[d50c010c06298d00]::ErrorGuaranteed>, rustc_driver_impl[4ea838747b1f4058]::run_compiler::{closure#1}>::{closure#0}, core[8666913e49efa5c]::result::Result<(), rustc_span[d50c010c06298d00]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[8666913e49efa5c]::result::Result<(), rustc_span[d50c010c06298d00]::ErrorGuaranteed>>::{closure#1} as core[8666913e49efa5c]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  30:     0x7ff80abb01d3 - __pthread_start

error: the compiler unexpectedly panicked. this is a bug.


note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.75.0-nightly (4226f40f7 2023-10-09) running on x86_64-apple-darwin

note: compiler flags: -Z threads=1 -Z simulate-remapped-rust-src-base=/rustc/FAKE_PREFIX -Z translate-remapped-path-to-local-path=no -Z ignore-directory-in-diagnostics-source-blocks=/Users/runner/.cargo -C codegen-units=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z write-long-types-to-disk=no -C strip=debuginfo -C prefer-dynamic -C rpath -C debuginfo=0 -Z treat-err-as-bug=1
query stack during panic:
#0 [resolver_for_lowering] getting the resolver for lowering
end of query stack
------------------------------------------

bors · 2023-10-09T20:06:38Z

💔 Test failed - checks-actions

Benjamin-L · 2023-10-09T20:17:49Z

That looks... very unlikely to be related to this change :)

tmiasko · 2023-10-10T21:37:50Z

@bors retry

bors · 2023-10-10T22:24:30Z

⌛ Testing commit 50246b0 with merge 1b2137f...

…uviper Implement `slice::split_once` and `slice::rsplit_once` Feature gate is `slice_split_once` and tracking issue is rust-lang#112811. These are equivalents to the existing `str::split_once` and `str::rsplit_once` methods.

rust-log-analyzer · 2023-10-10T23:38:09Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

tests\ui-toml\undocumented_unsafe_blocks\undocumented_unsafe_blocks.rs (default) ... ok
tests\ui-toml\undocumented_unsafe_blocks\undocumented_unsafe_blocks.rs (disabled) ... ok

tests\ui-toml\doc_valid_idents_replace\doc_markdown.rs FAILED:
command: "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\clippy-driver.exe" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Dwarnings" "-Ldependency=C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps" "--extern=clippy_lints=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libclippy_lints-5e8d785e054edb28.rlib" "--extern=clippy_utils=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libclippy_utils-0cf228b0c1780fd5.rlib" "--extern=futures=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libfutures-a074388a1bf2e009.rlib" "--extern=if_chain=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libif_chain-ba0253edeba7a8f0.rlib" "--extern=itertools=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libitertools-6894b4f3e8c5523f.rlib" "--extern=parking_lot=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libparking_lot-f87e1900e520ff9b.rlib" "--extern=quote=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libquote-3ebce4a1d5d43cf1.rlib" "--extern=regex=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libregex-3e46ad2dfdd0c657.rlib" "--extern=serde=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libserde-12500b7f802b2beb.rlib" "--extern=serde_derive=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\release\\deps\\serde_derive-67ed154847593e2b.dll" "--extern=syn=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libsyn-bc3ce53f417d339c.rlib" "--extern=tokio=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libtokio-159ee9fbda356223.rlib" "-Ldependency=C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\release\\deps" "--out-dir" "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\ui_test" "tests\\ui-toml\\doc_valid_idents_replace\\doc_markdown.fixed" "--edition" "2021" "--crate-name" "doc_markdown"
called `Result::unwrap()` on an `Err` value: tests failed

Location:
    C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\ui_test-0.20.0\src\lib.rs:362:13
    C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\ui_test-0.20.0\src\lib.rs:362:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

rustfix failed with exit code: 1

full stderr:
error: failed to write \\?\C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\ui_test\libdoc_markdown.rmeta: Access is denied. (os error 5)
error: aborting due to previous error


full stdout:

bors · 2023-10-10T23:38:41Z

💔 Test failed - checks-actions

cuviper · 2023-10-11T01:20:35Z

@bors retry

bors · 2023-10-11T05:31:13Z

⌛ Testing commit 50246b0 with merge 15b91c8...

…uviper Implement `slice::split_once` and `slice::rsplit_once` Feature gate is `slice_split_once` and tracking issue is rust-lang#112811. These are equivalents to the existing `str::split_once` and `str::rsplit_once` methods.

rust-log-analyzer · 2023-10-11T06:12:59Z

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] serde test:false 8.438
[RUSTC-TIMING] rustdoc_json_types test:false 3.027
[RUSTC-TIMING] basic_toml test:false 1.413
   Compiling askama_derive v0.12.1
rustc: /checkout/src/llvm-project/llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:3269: virtual bool {anonymous}::AArch64InstructionSelector::select(llvm::MachineInstr&): Assertion `(*RBI.getRegBank(DefReg, MRI, TRI)).getID() == AArch64::GPRRegBankID && "Unexpected ext regbank"' failed.
[RUSTC-TIMING] askama_derive test:false 3.613
rustc exited with signal: 6 (SIGABRT) (core dumped)
error: could not compile `askama_derive` (lib)
Caused by:
Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name askama_derive --edition=2021 /cargo/registry/src/index.crates.io-6f17d22bba15001f/askama_derive-0.12.1/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C embed-bitcode=no --cfg 'feature="basic-toml"' --cfg 'feature="config"' --cfg 'feature="serde"' -Zunstable-options --check-cfg 'values(feature, "basic-toml", "config", "humansize", "markdown", "num-traits", "serde", "serde-json", "serde-yaml", "urlencode", "with-actix-web", "with-axum", "with-gotham", "with-hyper", "with-mendes", "with-rocket", "with-tide", "with-warp")' --check-cfg 'names()' --check-cfg 'values()' -C metadata=c6fd582be4a78c11 -C extra-filename=-c6fd582be4a78c11 --out-dir /checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/release/deps -L dependency=/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/release/deps --extern basic_toml=/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/release/deps/libbasic_toml-16e0fe27f835abe3.rlib --extern mime=/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/release/deps/libmime-40a55bc9c87d1a95.rlib --extern mime_guess=/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/release/deps/libmime_guess-e91d4750de79940a.rlib --extern nom=/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/release/deps/libnom-e97641a3ac4b7876.rlib --extern proc_macro2=/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/release/deps/libproc_macro2-cd61893e4b094913.rlib --extern quote=/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/release/deps/libquote-ef7a1e1ac6d0b969.rlib --extern serde=/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/release/deps/libserde-78af758edf667aa2.rlib --extern syn=/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/release/deps/libsyn-24867c58ae3910e4.rlib --extern proc_macro --cap-lints allow -Z binary-dep-depinfo` (exit status: 254)
  local time: Wed Oct 11 06:12:37 UTC 2023
  network time: Wed, 11 Oct 2023 06:12:37 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2023-10-11T06:14:06Z

💔 Test failed - checks-actions

Noratrieb · 2023-10-11T06:48:23Z

rustc, are you fine?
@bors retry

bors · 2023-10-11T08:19:17Z

⌛ Testing commit 50246b0 with merge 156da98...

bors · 2023-10-11T10:06:11Z

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 156da98 to master...

rust-timer · 2023-10-11T11:28:02Z

Finished benchmarking commit (156da98): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.8%, 1.0%]	2
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-4.7%	[-4.7%, -4.7%]	1
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 627.49s -> 628.239s (0.12%)
Artifact size: 271.28 MiB -> 271.29 MiB (0.00%)

Implement slice::split_once and slice::rsplit_once

50246b0

Feature gate is slice_split_once and tracking issue is rust-lang#112811.

rustbot assigned m-ou-se Jun 20, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 20, 2023

Benjamin-L mentioned this pull request Jun 20, 2023

Tracking Issue for slice_split_once #112811

Open

4 tasks

rustbot assigned cuviper and unassigned m-ou-se Oct 8, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 11, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 11, 2023

bors merged commit 156da98 into rust-lang:master Oct 11, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Oct 11, 2023

Dajamante mentioned this pull request Oct 12, 2023

Pull upstream master 2023 10 12 ferrocene/ferrocene#48

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `slice::split_once` and `slice::rsplit_once` #112818

Implement `slice::split_once` and `slice::rsplit_once` #112818

Benjamin-L commented Jun 20, 2023

rustbot commented Jun 20, 2023

Benjamin-L commented Oct 8, 2023

cuviper commented Oct 9, 2023

bors commented Oct 9, 2023

bors commented Oct 9, 2023

rust-log-analyzer commented Oct 9, 2023

bors commented Oct 9, 2023

Benjamin-L commented Oct 9, 2023

tmiasko commented Oct 10, 2023

bors commented Oct 10, 2023

rust-log-analyzer commented Oct 10, 2023

bors commented Oct 10, 2023

cuviper commented Oct 11, 2023

bors commented Oct 11, 2023

rust-log-analyzer commented Oct 11, 2023

bors commented Oct 11, 2023

Noratrieb commented Oct 11, 2023

bors commented Oct 11, 2023

bors commented Oct 11, 2023

rust-timer commented Oct 11, 2023

Implement slice::split_once and slice::rsplit_once #112818

Implement slice::split_once and slice::rsplit_once #112818

Conversation

Benjamin-L commented Jun 20, 2023

rustbot commented Jun 20, 2023

Benjamin-L commented Oct 8, 2023

cuviper commented Oct 9, 2023

bors commented Oct 9, 2023

bors commented Oct 9, 2023

rust-log-analyzer commented Oct 9, 2023

bors commented Oct 9, 2023

Benjamin-L commented Oct 9, 2023

tmiasko commented Oct 10, 2023

bors commented Oct 10, 2023

rust-log-analyzer commented Oct 10, 2023

bors commented Oct 10, 2023

cuviper commented Oct 11, 2023

bors commented Oct 11, 2023

rust-log-analyzer commented Oct 11, 2023

bors commented Oct 11, 2023

Noratrieb commented Oct 11, 2023

bors commented Oct 11, 2023

bors commented Oct 11, 2023

rust-timer commented Oct 11, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Implement `slice::split_once` and `slice::rsplit_once` #112818

Implement `slice::split_once` and `slice::rsplit_once` #112818